fix: add missing dependency has-symbols #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released in v1.1.1. |
|
It happened during @ljharb’s rebase of #19 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
util.promisifyis usinghas-symbolswithout declaring it as a dependency which makes it rely on something else in the dependency tree to declare it and hoisting to be gracious enough to place it in an accesible location neither of which is guaranteed. It was moved fromdependenciestodevDependenciesin 8f8631bNoticed by the Yarn PnP test in preactjs/preact-cli#1418
How did you fix it?
Moved it back