Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event rrules do not properly work #141

Closed
symbiosdotwiki opened this issue Sep 2, 2015 · 11 comments
Closed

Event rrules do not properly work #141

symbiosdotwiki opened this issue Sep 2, 2015 · 11 comments
Labels
Milestone

Comments

@symbiosdotwiki
Copy link
Contributor

I have a fix that I will push, but basically given this case:

Start: Saturday August 15
End Recur: Tuesday September 15 2015
Rule: Weekly, bymonthday:29,30

The event will recur on both Saturday September 29 and Sunday September 30

This is an issue with rrule, or something, but I made a function that checks for these issues and corrects.

@llazzaro
Copy link
Owner

llazzaro commented Sep 2, 2015

can you add an unit test for that case?

@symbiosdotwiki
Copy link
Contributor Author

there is also an issue with events where the rules, etc make the event non-existent. I also corrected for that.

I am working on writing some functionality to test whether an event is contained in another event. This is useful for the case when you have "availability" events and you want to see if a possible event resides in that availability.

I'll add a test for the final pull request.

@gabn88
Copy link
Contributor

gabn88 commented Jan 13, 2016

Any news on this?

@symbiosdotwiki
Copy link
Contributor Author

Never got around to writing tests, but you can check out the original pull request for the algorithm

@symbiosdotwiki
Copy link
Contributor Author

I guess I never pushed those either, oops.

I can post the code later today

@gabn88
Copy link
Contributor

gabn88 commented Jan 13, 2016

That would be great. I'm just getting to know this module as my last resort to get my customers recurring events without end date wish implemented in a properly fashion

@symbiosdotwiki
Copy link
Contributor Author

@gabn88
Copy link
Contributor

gabn88 commented Jan 13, 2016

Great! I will check it out!

@gabn88
Copy link
Contributor

gabn88 commented Jan 13, 2016

If I understand it correctly, your way to integrate this app was to copy the necessary bits and build of you own Scheduler app of it? I was thinking about doing it the same way.

@symbiosdotwiki
Copy link
Contributor Author

You definitely will need to build another app that references this app.
Only use the schedule app for the base time things.
On Jan 13, 2016 3:20 PM, "gabn88" notifications@github.com wrote:

If I understand it correctly, your way to integrate this app was to copy
the necessary bits and build of you own Scheduler app of it? I was thinking
about doing it the same way.


Reply to this email directly or view it on GitHub
#141 (comment)
.

symbiosdotwiki pushed a commit to symbiosdotwiki/django-scheduler that referenced this issue Mar 7, 2016
@symbiosdotwiki
Copy link
Contributor Author

fixed in recent pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants