-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event rrules do not properly work #141
Comments
can you add an unit test for that case? |
there is also an issue with events where the rules, etc make the event non-existent. I also corrected for that. I am working on writing some functionality to test whether an event is contained in another event. This is useful for the case when you have "availability" events and you want to see if a possible event resides in that availability. I'll add a test for the final pull request. |
Any news on this? |
Never got around to writing tests, but you can check out the original pull request for the algorithm |
I guess I never pushed those either, oops. I can post the code later today |
That would be great. I'm just getting to know this module as my last resort to get my customers recurring events without end date wish implemented in a properly fashion |
Great! I will check it out! |
If I understand it correctly, your way to integrate this app was to copy the necessary bits and build of you own Scheduler app of it? I was thinking about doing it the same way. |
You definitely will need to build another app that references this app.
|
fixed in recent pr |
I have a fix that I will push, but basically given this case:
Start: Saturday August 15
End Recur: Tuesday September 15 2015
Rule: Weekly, bymonthday:29,30
The event will recur on both Saturday September 29 and Sunday September 30
This is an issue with rrule, or something, but I made a function that checks for these issues and corrects.
The text was updated successfully, but these errors were encountered: