all: replace rickypai/natsort with internal/natsort #94
+330
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code is written by Frits van Bommel (@fvbommel) and released under an MIT license. This commit copies the code of sortorder without modification, and inclues the LICENSE file of the parent directory (util). Follow-up commits will relax the vanity import and make minor adjustments to the API.
…s to Less Also, remove usage of github.com/xlab/handysort from test cases.
Prior to this commit, the array `a` as defined below:
a := []string{
"foo20",
"foo.bar",
"foo2",
"foo.10",
"foo.1",
"foo.20",
"foo.11",
"foo1",
"foobar",
"foo21",
"foo10",
"foo11",
"foo.21",
"foo.2",
}
would be sorted as follows:
"foo1"
"foo2"
"foo10"
"foo11"
"foo20"
"foo21"
"foo.1"
"foo.2"
"foo.10"
"foo.11"
"foo.20"
"foo.21"
"foo.bar"
"foobar"
That is, digits would be considered "less" than
other characters.
After this commit, the same slice would be sorted as
follows:
"foo.1"
"foo.2"
"foo.10"
"foo.11"
"foo.20"
"foo.21"
"foo.bar"
"foo1"
"foo2"
"foo10"
"foo11"
"foo20"
"foo21"
"foobar"
This conforms to the sorting behaviour of many
File Managers and may thus be considered expected
behaviour for users.
Note, this is the first commit to internal/natsort
that diverges in functionality from the sortorder
package of @fvbommel. As such, natsort should now
be considered a fork and not just a vendored mirror.
As stated in the README.md document of the
internal/natsort directory, the original code written
by Frits van Bommel is licensed under an MIT license.
Any subsequent changes made to the code base after
the fork are hereby released into the public domain.
This commit also extends the test cases.
1 task
|
The CI passed for Go 1.11, and failed on tip, with the following: Should we set Edit: golangci-lint issue is tracked upstream at golangci/golangci-lint#595. Since this passes on Go 1.11, I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit 757f554 for details.
Updates #92.
cc: @pwaller