Skip to content

fix: Makefile fixes for MacOS #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix: Makefile fixes for MacOS #146

merged 1 commit into from
Aug 19, 2025

Conversation

@shmuelk
Copy link
Collaborator

@shmuelk shmuelk commented Aug 19, 2025

This PR fixes two issues with the Makefile on MacOS. In particular:

  1. It removes the need to add TARGETOS=linux when running make image-build
  2. It removes the need to add TARGETARCH=X86_64 when running make download-tokenizer

@shmuelk
Makefile fixes for MacOS
fd85c01 
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@shmuelk shmuelk requested a review from mayabar August 19, 2025 10:57
@shmuelk shmuelk merged commit efa82a5 into llm-d:main Aug 19, 2025
3 checks passed
@shmuelk shmuelk deleted the make-fixes branch August 19, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayabar mayabar mayabar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shmuelk @mayabar