Skip to content
This repository has been archived by the owner on Apr 23, 2020. It is now read-only.

Commit

Permalink
fdiv/frem of undef can produce undef, because the undef operand
Browse files Browse the repository at this point in the history
can be a SNaN.  We could be more aggressive and turn this into 
unreachable, but that is less nice, and not really worth it.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47313 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
lattner committed Feb 19, 2008
1 parent 3890561 commit 50b2ca4
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions lib/Transforms/Scalar/InstructionCombining.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2590,9 +2590,13 @@ Instruction *InstCombiner::visitMul(BinaryOperator &I) {
Instruction *InstCombiner::commonDivTransforms(BinaryOperator &I) {
Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);

// undef / X -> 0
if (isa<UndefValue>(Op0))
// undef / X -> 0 for integer.
// undef / X -> undef for FP (the undef could be a snan).
if (isa<UndefValue>(Op0)) {
if (Op0->getType()->isFPOrFPVector())
return ReplaceInstUsesWith(I, Op0);
return ReplaceInstUsesWith(I, Constant::getNullValue(I.getType()));
}

// X / undef -> undef
if (isa<UndefValue>(Op1))
Expand Down Expand Up @@ -2821,13 +2825,16 @@ static Constant *GetFactor(Value *V) {
Instruction *InstCombiner::commonRemTransforms(BinaryOperator &I) {
Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);

// 0 % X == 0, we don't need to preserve faults!
// 0 % X == 0 for integer, we don't need to preserve faults!
if (Constant *LHS = dyn_cast<Constant>(Op0))
if (LHS->isNullValue())
return ReplaceInstUsesWith(I, Constant::getNullValue(I.getType()));

if (isa<UndefValue>(Op0)) // undef % X -> 0
if (isa<UndefValue>(Op0)) { // undef % X -> 0
if (I.getType()->isFPOrFPVector())
return ReplaceInstUsesWith(I, Op0); // X % undef -> undef (could be SNaN)
return ReplaceInstUsesWith(I, Constant::getNullValue(I.getType()));
}
if (isa<UndefValue>(Op1))
return ReplaceInstUsesWith(I, Op1); // X % undef -> undef

Expand Down

0 comments on commit 50b2ca4

Please sign in to comment.