[RTGTest] Add some registers #7924
Open
+295
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Dec 4, 2024
Comment on lines
+47
to
+58
| Virtual registers will be assigned a concrete register when running register | ||
| allocation. |
There was a problem hiding this comment.
This probably doesn't make sense for a test dialect, but in practice, would you have virtual registers as a separate op that cannot be CSEd, and actual ISA register as something "pure" or maybe even "constant-like"?
There was a problem hiding this comment.
Good point! Having concrete registers CSE would be very nice. Having separate ops for concrete and virtual registers complicates register allocation a bit but makes elaboration easier. Let me think about that a bit more.
maerhart
commented
Dec 5, 2024
|
|
||
| // Flat allocation of unique IDs to all registers. The actual ID value does not | ||
| // matter. | ||
| def RegisterAttr : I32EnumAttr< |
There was a problem hiding this comment.
I think ideally this attribute should be of IntegerRegisterType, not I32. It's not a big deal for now though.
maerhart
force-pushed
the
maerhart-rtg-getsizeops-elaboration
branch
from
31e652b to
81f191f
Compare
This adds some registers to later test passes such as register alloction, assembly emission, correct behavior of the elaboration pass in presence of registers, etc. Co-authored-by: Andrew Lenharth <andrew@lenharth.org>
maerhart
force-pushed
the
maerhart-rtgtest-registers
branch
from
49fccfd to
d868ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some registers to later test passes such as register alloction, assembly emission, correct behavior of the elaboration pass in presence of registers, etc.