-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SMT] Add Z3 lowering for set_logic op #7930
Conversation
I believe most solvers would treat set-logic in such as way. I'm curios if it makes sense to add optional logic attribute to |
We thought the same, but decided that we should probably use SMTLIB as the golden reference - agreed that most solvers probably only support it as a one-off, but it would be a shame not to support functionality that some solvers could have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add an integration test for Z3 set-logic?
Not sure what you mean, there's an integration test for the Z3 export added in integration_test/Dialect/SMT/basic.mlir? |
Oh sorry, I overlooked that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! |
Slightly more complicated than this would ideally be because Z3 handles different logics with a separate solver constructor rather than as a function to be called on the solver.