Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMT] Add Z3 lowering for set_logic op #7930

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Dec 2, 2024

Slightly more complicated than this would ideally be because Z3 handles different logics with a separate solver constructor rather than as a function to be called on the solver.

@TaoBi22 TaoBi22 requested a review from maerhart as a code owner December 2, 2024 11:39
@uenoku
Copy link
Member

uenoku commented Dec 3, 2024

Z3 with a separate solver constructor rather than as a function to be called on the solver.

I believe most solvers would treat set-logic in such as way. I'm curios if it makes sense to add optional logic attribute to smt.solver op 🤔

@TaoBi22
Copy link
Contributor Author

TaoBi22 commented Dec 3, 2024

I'm curios if it makes sense to add optional logic attribute to smt.solver op 🤔

We thought the same, but decided that we should probably use SMTLIB as the golden reference - agreed that most solvers probably only support it as a one-off, but it would be a shame not to support functionality that some solvers could have

Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an integration test for Z3 set-logic?

lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
lib/Conversion/SMTToZ3LLVM/LowerSMTToZ3LLVM.cpp Outdated Show resolved Hide resolved
test/Conversion/SMTToZ3LLVM/smt-to-z3-llvm.mlir Outdated Show resolved Hide resolved
@TaoBi22
Copy link
Contributor Author

TaoBi22 commented Dec 5, 2024

Should we add an integration test for Z3 set-logic?

Not sure what you mean, there's an integration test for the Z3 export added in integration_test/Dialect/SMT/basic.mlir?

@maerhart
Copy link
Member

maerhart commented Dec 6, 2024

Not sure what you mean, there's an integration test for the Z3 export added in integration_test/Dialect/SMT/basic.mlir?

Oh sorry, I overlooked that one.

Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TaoBi22
Copy link
Contributor Author

TaoBi22 commented Dec 6, 2024

Thanks!

@TaoBi22 TaoBi22 merged commit 61d5eae into llvm:main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants