Skip to content

Commit 04a803a

Browse files
committed
Remove hasDynamicDimensions
1 parent f3d6e68 commit 04a803a

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -910,20 +910,6 @@ static Value broadcastDynamicDimensions(PatternRewriter &rewriter, Location loc,
910910
return operand;
911911
}
912912

913-
static bool hasDynamicDimensions(ValueRange operands) {
914-
for (auto operand : operands) {
915-
auto rankedTensorType = cast_or_null<RankedTensorType>(operand.getType());
916-
if (!rankedTensorType)
917-
continue;
918-
int64_t rank = rankedTensorType.getRank();
919-
for (auto dim : llvm::seq<int64_t>(0, rank)) {
920-
if (rankedTensorType.isDynamicDim(dim))
921-
return true;
922-
}
923-
}
924-
return false;
925-
}
926-
927913
static SmallVector<Value>
928914
broadcastDynamicDimensions(PatternRewriter &rewriter, Location loc,
929915
IndexPool &indexPool, ValueRange operands,
@@ -933,7 +919,16 @@ broadcastDynamicDimensions(PatternRewriter &rewriter, Location loc,
933919
if (operands.size() == 1)
934920
return operands;
935921

936-
if (!hasDynamicDimensions(operands))
922+
// No need to broadcast for static shape
923+
bool hasDynamic = false;
924+
for (auto op : operands) {
925+
const auto tType = dyn_cast<RankedTensorType>(op.getType());
926+
if (tType && !tType.hasStaticShape()) {
927+
hasDynamic = true;
928+
break;
929+
}
930+
}
931+
if (!hasDynamic)
937932
return operands;
938933

939934
// Broadcast dynamic dimensions operand by operand

0 commit comments

Comments
 (0)