Skip to content

Commit fcab66d

Browse files
committed
[lldb] Findtypes -gmodules fix for too many matches
Apparently the intention was to copy the condition above: if (types.GetSize() >= max_matches) break; So that if the iteration stopped because of too many matches we do not add even more matches in this 'Clang modules' block downward. It was implemented by: SymbolFileDWARF: Unconditionally scan through clang modules. NFCish fe9eaad Differential Revision: https://reviews.llvm.org/D77336
1 parent 1fcfd30 commit fcab66d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2407,7 +2407,7 @@ void SymbolFileDWARF::FindTypes(
24072407
// Next search through the reachable Clang modules. This only applies for
24082408
// DWARF objects compiled with -gmodules that haven't been processed by
24092409
// dsymutil.
2410-
if (num_die_matches < max_matches) {
2410+
if (types.GetSize() < max_matches) {
24112411
UpdateExternalModuleListIfNeeded();
24122412

24132413
for (const auto &pair : m_external_type_modules)

0 commit comments

Comments
 (0)