Skip to content

[libc++][string] Remove potential non-trailing 0-length array #105865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serge-sans-paille merged 7 commits into from
Sep 10, 2024
Merged

[libc++][string] Remove potential non-trailing 0-length array #105865

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cbdce6
[libc++][string] Remove potential non-trailing 0-length array
serge-sans-paille Aug 23, 2024
960e989
fixup! [libc++][string] Remove potential non-trailing 0-length array
serge-sans-paille Aug 24, 2024
f17a954
fixup! [libc++][string] Remove potential non-trailing 0-length array
serge-sans-paille Aug 29, 2024
72ff46d
fixup! fixup! [libc++][string] Remove potential non-trailing 0-length…
serge-sans-paille Sep 8, 2024
40da20f
fixup! fixup! fixup! [libc++][string] Remove potential non-trailing 0…
serge-sans-paille Sep 8, 2024
efc9123
fixup! fixup! fixup! fixup! [libc++][string] Remove potential non-tra…
serge-sans-paille Sep 9, 2024
1151a32
Reduce the diff
ldionne Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions libcxx/include/string
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,14 @@ struct __can_be_converted_to_string_view
struct __uninitialized_size_tag {};
struct __init_with_sentinel_tag {};

template <size_t _PaddingSize>
struct __padding {
char __padding_[_PaddingSize];
};

template <>
struct __padding<0> {};

template <class _CharT, class _Traits, class _Allocator>
class basic_string {
private:
Expand Down Expand Up @@ -853,7 +861,7 @@ private:

struct __short {
value_type __data_[__min_cap];
unsigned char __padding_[sizeof(value_type) - 1];
_LIBCPP_NO_UNIQUE_ADDRESS __padding<sizeof(value_type) - 1> __padding_;
unsigned char __size_ : 7;
unsigned char __is_long_ : 1;
};
Expand Down Expand Up @@ -905,7 +913,7 @@ private:
unsigned char __is_long_ : 1;
unsigned char __size_ : 7;
};
char __padding_[sizeof(value_type) - 1];
_LIBCPP_NO_UNIQUE_ADDRESS __padding<sizeof(value_type) - 1> __padding_;
value_type __data_[__min_cap];
};

Expand Down