diff --git a/llvm/lib/Transforms/Scalar/JumpThreading.cpp b/llvm/lib/Transforms/Scalar/JumpThreading.cpp index 18d5f201413c8..5c112a429c6bc 100644 --- a/llvm/lib/Transforms/Scalar/JumpThreading.cpp +++ b/llvm/lib/Transforms/Scalar/JumpThreading.cpp @@ -2530,17 +2530,16 @@ void JumpThreadingPass::updateBlockFreqAndEdgeWeight(BasicBlock *PredBB, // frequency of BB. auto BBOrigFreq = BFI->getBlockFreq(BB); auto NewBBFreq = BFI->getBlockFreq(NewBB); - auto BB2SuccBBFreq = BBOrigFreq * BPI->getEdgeProbability(BB, SuccBB); auto BBNewFreq = BBOrigFreq - NewBBFreq; BFI->setBlockFreq(BB, BBNewFreq); // Collect updated outgoing edges' frequencies from BB and use them to update // edge probabilities. SmallVector BBSuccFreq; - for (BasicBlock *Succ : successors(BB)) { - auto SuccFreq = (Succ == SuccBB) - ? BB2SuccBBFreq - NewBBFreq - : BBOrigFreq * BPI->getEdgeProbability(BB, Succ); + for (succ_iterator I = succ_begin(BB), E = succ_end(BB); I != E; ++I) { + auto BB2SuccBBFreq = + BBOrigFreq * BPI->getEdgeProbability(BB, I.getSuccessorIndex()); + auto SuccFreq = (*I == SuccBB) ? BB2SuccBBFreq - NewBBFreq : BB2SuccBBFreq; BBSuccFreq.push_back(SuccFreq.getFrequency()); } diff --git a/llvm/test/Transforms/JumpThreading/thread-prob-8.ll b/llvm/test/Transforms/JumpThreading/thread-prob-8.ll new file mode 100644 index 0000000000000..b63c789515966 --- /dev/null +++ b/llvm/test/Transforms/JumpThreading/thread-prob-8.ll @@ -0,0 +1,42 @@ +; RUN: opt -debug-only=branch-prob -passes=jump-threading -S %s 2>&1 | FileCheck %s +; REQUIRES: asserts + +; Make sure that edges' probabilities would not accumulate if they are +; the same target BB. +; Edge L0 -> 2 and L0 -> 3 's targets are both L2, but their respective +; probability should not be L0 -> L2, because prob[L0->L2] equls to +; prob[L0->2] + prob[L0->3] + +; CHECK: Computing probabilities for entry +; CHECK: eraseBlock L0 +; CHECK-NOT: set edge L0 -> 0 successor probability to 0x12492492 / 0x80000000 = 14.29% +; CHECK-NOT: set edge L0 -> 1 successor probability to 0x24924925 / 0x80000000 = 28.57% +; CHECK-NOT: set edge L0 -> 2 successor probability to 0x24924925 / 0x80000000 = 28.57% +; CHECK-NOT: set edge L0 -> 3 successor probability to 0x24924925 / 0x80000000 = 28.57% +; CHECK: set edge L0 -> 0 successor probability to 0x1999999a / 0x80000000 = 20.00% +; CHECK: set edge L0 -> 1 successor probability to 0x33333333 / 0x80000000 = 40.00% +; CHECK: set edge L0 -> 2 successor probability to 0x1999999a / 0x80000000 = 20.00% +; CHECK: set edge L0 -> 3 successor probability to 0x1999999a / 0x80000000 = 20.00% +; CHECK-NOT: !0 = !{!"branch_weights", i32 306783378, i32 613566757, i32 613566757, i32 613566757} +; CHECK: !0 = !{!"branch_weights", i32 429496730, i32 858993459, i32 429496730, i32 429496730} +define void @test_switch(i1 %cond, i8 %value) nounwind { +entry: + br i1 %cond, label %L0, label %L4 +L0: + %expr = select i1 %cond, i8 1, i8 %value + switch i8 %expr, label %L3 [ + i8 1, label %L1 + i8 2, label %L2 + i8 3, label %L2 + ], !prof !0 + +L1: + ret void +L2: + ret void +L3: + ret void +L4: + br label %L0 +} +!0 = !{!"branch_weights", i32 1, i32 7, i32 1, i32 1}