RuntimeLibcalls: Fix missing const on getLibcallNames #143074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-llvm-ir Author: Matt Arsenault (arsenm) ChangesThis is made simpler by just returning the array ref instead of Full diff: https://github.com/llvm/llvm-project/pull/143074.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/RuntimeLibcalls.h b/llvm/include/llvm/IR/RuntimeLibcalls.h
index 26c085031a48a..a16c317fd8d41 100644
--- a/llvm/include/llvm/IR/RuntimeLibcalls.h
+++ b/llvm/include/llvm/IR/RuntimeLibcalls.h
@@ -68,10 +68,7 @@ struct RuntimeLibcallsInfo {
return LibcallCallingConvs[Call];
}
- iterator_range<const char **> getLibcallNames() {
- return llvm::make_range(LibcallRoutineNames,
- LibcallRoutineNames + RTLIB::UNKNOWN_LIBCALL);
- }
+ ArrayRef<const char *> getLibcallNames() const { return LibcallRoutineNames; }
private:
/// Stores the name each libcall.
|
nikic
reviewed
Jun 6, 2025
| return llvm::make_range(LibcallRoutineNames, | ||
| LibcallRoutineNames + RTLIB::UNKNOWN_LIBCALL); | ||
| } | ||
| ArrayRef<const char *> getLibcallNames() const { return LibcallRoutineNames; } |
Contributor
There was a problem hiding this comment.
If I'm reading this right, this is now going to include the entry for UNKNOWN_LIBCALL as well. Is that intentional?
Contributor
Author
There was a problem hiding this comment.
Not intentional, but it also doesn't really matter. Could drop_back, but it just appears as another null entry which uses have to tolerate anyway
This is made simpler by just returning the array ref instead of the fancy range.
arsenm
force-pushed
the
users/arsenm/runtime-libcalls/fix-missing-const-getLibcallNames
branch
from
f57d03b to
16b0b3e
Compare
arsenm
deleted the
users/arsenm/runtime-libcalls/fix-missing-const-getLibcallNames
branch
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
This is made simpler by just returning the array ref instead of the fancy range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is made simpler by just returning the array ref instead of
the fancy range.