From 0de58c7926028313bab58cdaa196a170a52a4497 Mon Sep 17 00:00:00 2001 From: Chauhan Jaydeep Ashwinbhai Date: Wed, 10 Dec 2025 05:10:33 -0800 Subject: [PATCH] [AsmPrinter][NFC] Reuse Target Triple varible --- llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index c459b80baf4ab..6d80d108dd730 100644 --- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -488,6 +488,7 @@ bool AsmPrinter::doInitialization(Module &M) { HasSplitStack = false; HasNoSplitStack = false; DbgInfoAvailable = !M.debug_compile_units().empty(); + const Triple &Target = TM.getTargetTriple(); AddrLabelSymbols = nullptr; @@ -500,7 +501,7 @@ bool AsmPrinter::doInitialization(Module &M) { // after emitting the .file pseudo-op. This allows additional // information (such as the embedded command line) to be associated // with all sections in the object file rather than a single section. - if (!TM.getTargetTriple().isOSBinFormatXCOFF()) + if (!Target.isOSBinFormatXCOFF()) OutStreamer->initSections(false, *TM.getMCSubtargetInfo()); // Emit the version-min deployment target directive if needed. @@ -511,7 +512,6 @@ bool AsmPrinter::doInitialization(Module &M) { // alternative is duplicated code in each of the target asm printers that // use the directive, where it would need the same conditionalization // anyway. - const Triple &Target = TM.getTargetTriple(); if (Target.isOSBinFormatMachO() && Target.isOSDarwin()) { Triple TVT(M.getDarwinTargetVariantTriple()); OutStreamer->emitVersionForTarget( @@ -547,7 +547,7 @@ bool AsmPrinter::doInitialization(Module &M) { // On AIX, emit bytes for llvm.commandline metadata after .file so that the // C_INFO symbol is preserved if any csect is kept by the linker. - if (TM.getTargetTriple().isOSBinFormatXCOFF()) { + if (Target.isOSBinFormatXCOFF()) { emitModuleCommandLines(M); // Now we can generate section information. OutStreamer->switchSection( @@ -586,9 +586,8 @@ bool AsmPrinter::doInitialization(Module &M) { bool EmitCodeView = M.getCodeViewFlag(); // On Windows targets, emit minimal CodeView compiler info even when debug // info is disabled. - if ((TM.getTargetTriple().isOSWindows() && - M.getNamedMetadata("llvm.dbg.cu")) || - (TM.getTargetTriple().isUEFI() && EmitCodeView)) + if ((Target.isOSWindows() && M.getNamedMetadata("llvm.dbg.cu")) || + (Target.isUEFI() && EmitCodeView)) Handlers.push_back(std::make_unique(this)); if (!EmitCodeView || M.getDwarfVersion()) { if (hasDebugInfo()) { @@ -2681,6 +2680,7 @@ bool AsmPrinter::doFinalization(Module &M) { // accesses to MF specific features at the module level and so that // we can conditionalize accesses based on whether or not it is nullptr. MF = nullptr; + const Triple &Target = TM.getTargetTriple(); std::vector GlobalsToTag; for (GlobalVariable &G : M.globals()) { @@ -2720,7 +2720,7 @@ bool AsmPrinter::doFinalization(Module &M) { MCSymbol *Name = getSymbol(&F); // Function getSymbol gives us the function descriptor symbol for XCOFF. - if (!TM.getTargetTriple().isOSBinFormatXCOFF()) { + if (!Target.isOSBinFormatXCOFF()) { GlobalValue::VisibilityTypes V = F.getVisibility(); if (V == GlobalValue::DefaultVisibility) continue; @@ -2753,7 +2753,7 @@ bool AsmPrinter::doFinalization(Module &M) { TLOF.emitModuleMetadata(*OutStreamer, M); - if (TM.getTargetTriple().isOSBinFormatELF()) { + if (Target.isOSBinFormatELF()) { MachineModuleInfoELF &MMIELF = MMI->getObjFileInfo(); // Output stubs for external and common global variables. @@ -2771,7 +2771,7 @@ bool AsmPrinter::doFinalization(Module &M) { } } - if (TM.getTargetTriple().isOSBinFormatCOFF()) { + if (Target.isOSBinFormatCOFF()) { MachineModuleInfoCOFF &MMICOFF = MMI->getObjFileInfo(); @@ -2884,7 +2884,7 @@ bool AsmPrinter::doFinalization(Module &M) { // Emit bytes for llvm.commandline metadata. // The command line metadata is emitted earlier on XCOFF. - if (!TM.getTargetTriple().isOSBinFormatXCOFF()) + if (!Target.isOSBinFormatXCOFF()) emitModuleCommandLines(M); // Emit .note.GNU-split-stack and .note.GNU-no-split-stack sections if @@ -2919,7 +2919,7 @@ bool AsmPrinter::doFinalization(Module &M) { } // Emit symbol partition specifications (ELF only). - if (TM.getTargetTriple().isOSBinFormatELF()) { + if (Target.isOSBinFormatELF()) { unsigned UniqueID = 0; for (const GlobalValue &GV : M.global_values()) { if (!GV.hasPartition() || GV.isDeclarationForLinker() ||