[mlir][transform] Improve error when merging of modules fails.

[ingomueller-net]

This resolved #69112.

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Ingo Müller (ingomueller-net)

Changes

This resolved #69112.

---

Full diff: https://github.com/llvm/llvm-project/pull/69331.diff

1 Files Affected:

• (modified) mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp (+2-2)

diff --git a/mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp b/mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
index 41feffffaf97b3f..e0bde020daf7c6f 100644
--- a/mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
+++ b/mlir/lib/Dialect/Transform/Transforms/TransformInterpreterUtils.cpp
@@ -176,8 +176,8 @@ LogicalResult transform::detail::assembleTransformLibraryFromPaths(
     for (OwningOpRef<ModuleOp> &parsedLibrary : parsedLibraries) {
       if (failed(transform::detail::mergeSymbolsInto(
               mergedParsedLibraries.get(), std::move(parsedLibrary))))
-        return mergedParsedLibraries->emitError()
-               << "failed to verify merged transform module";
+        return parsedLibrary->emitError()
+               << "failed to merge symbols into shared library module";
     }
   }
 

[ftynse]

I'm not sure this fixes the issue I originally raised. My point was that we shouldn't report two diagnostics for the same error, not the location or the contents of the second diagnostic.