Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] fix stdbit include test when not all entrypoints are available #80323

Merged
merged 3 commits into from
Feb 1, 2024
Merged

[libc] fix stdbit include test when not all entrypoints are available #80323

merged 3 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. [libc] fix stdbit include test when not all entrypoints are available 

    The intent of the test is to check that:
1. The type generic macros are defined.
2. Those macros dispatch to the correct underlying function.

The issue is that when new functionality is added to our stdbit.h without
rolling out the new entrypoint to all targets, this test breaks because our
generated stdbit.h will not contain declarations for the underlying function.
In that case, we should just declare the underlying functions first before
including our generated stdbit.h which just contains declarations. A definition
is a declaration, but redeclarations must match, hence the additions of
noexcept and extern "C".
    @nickdesaulniers
    nickdesaulniers committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e55fb44 View commit details
    Browse the repository at this point in the history

  2. appease formatter

    @nickdesaulniers
    nickdesaulniers committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7b1fa8f View commit details
    Browse the repository at this point in the history

  3. just test stdbit-macros.h rather than stdbit.h

    @nickdesaulniers
    nickdesaulniers committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4f847ed View commit details
    Browse the repository at this point in the history