Skip to content

Update XFAILs of reversebits tests for Vulkan #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

Update XFAILs of reversebits tests for Vulkan #519

merged 1 commit into from
Dec 1, 2025
+2 −8

Conversation

@Icohedron
Copy link
Contributor

@Icohedron Icohedron commented Nov 28, 2025 •
edited
Loading

This PR removes the XFAILs from the reversebits tests, and adds a new XFAIL on the 16-bit reversebits test with issue #518 tracking it.

Test results from scheduled runs today (2025-11-28):

╭────┬──────────────────────┬─────────────┬─────────────────────────────┬────────┬─────────────────────────────────────╮
│  # │      timestamp       │   run-id    │          workflow           │ status │                test                 │
├────┼──────────────────────┼─────────────┼─────────────────────────────┼────────┼─────────────────────────────────────┤
│  0 │ 2025-11-28T18:05:50Z │ 19771050617 │ Windows Vulkan AMD DXC      │ PASS   │ Feature/HLSLLib/reversebits.16.test │
│  1 │ 2025-11-28T18:05:50Z │ 19771050617 │ Windows Vulkan AMD DXC      │ PASS   │ Feature/HLSLLib/reversebits.32.test │
│  2 │ 2025-11-28T18:05:50Z │ 19771050617 │ Windows Vulkan AMD DXC      │ PASS   │ Feature/HLSLLib/reversebits.64.test │
│  3 │ 2025-11-28T22:01:55Z │ 19774580028 │ Windows Vulkan Intel DXC    │ PASS   │ Feature/HLSLLib/reversebits.16.test │
│  4 │ 2025-11-28T22:01:55Z │ 19774580028 │ Windows Vulkan Intel DXC    │ PASS   │ Feature/HLSLLib/reversebits.64.test │
│  5 │ 2025-11-28T22:01:55Z │ 19774580028 │ Windows Vulkan Intel DXC    │ PASS   │ Feature/HLSLLib/reversebits.32.test │
│  6 │ 2025-11-28T02:35:49Z │ 19752462306 │ Windows Vulkan NVIDIA DXC   │ PASS   │ Feature/HLSLLib/reversebits.16.test │
│  7 │ 2025-11-28T02:35:49Z │ 19752462306 │ Windows Vulkan NVIDIA DXC   │ PASS   │ Feature/HLSLLib/reversebits.64.test │
│  8 │ 2025-11-28T02:35:49Z │ 19752462306 │ Windows Vulkan NVIDIA DXC   │ PASS   │ Feature/HLSLLib/reversebits.32.test │
│  9 │ 2025-11-28T18:02:29Z │ 19770990351 │ Windows Vulkan QC DXC       │ PASS   │ Feature/HLSLLib/reversebits.16.test │
│ 10 │ 2025-11-28T18:02:29Z │ 19770990351 │ Windows Vulkan QC DXC       │ PASS   │ Feature/HLSLLib/reversebits.32.test │
│ 11 │ 2025-11-28T18:02:29Z │ 19770990351 │ Windows Vulkan QC DXC       │ PASS   │ Feature/HLSLLib/reversebits.64.test │
│ 12 │ 2025-11-28T22:06:03Z │ 19774646176 │ Windows Vulkan QC Clang     │ XFAIL  │ Feature/HLSLLib/reversebits.16.test │
│ 13 │ 2025-11-28T18:06:34Z │ 19771064332 │ Windows Vulkan AMD Clang    │ XPASS  │ Feature/HLSLLib/reversebits.16.test │
│ 14 │ 2025-11-28T18:06:34Z │ 19771064332 │ Windows Vulkan AMD Clang    │ XPASS  │ Feature/HLSLLib/reversebits.32.test │
│ 15 │ 2025-11-28T18:06:34Z │ 19771064332 │ Windows Vulkan AMD Clang    │ XPASS  │ Feature/HLSLLib/reversebits.64.test │
│ 16 │ 2025-11-28T20:04:28Z │ 19772907221 │ Windows Vulkan Intel Clang  │ XPASS  │ Feature/HLSLLib/reversebits.64.test │
│ 17 │ 2025-11-28T20:04:28Z │ 19772907221 │ Windows Vulkan Intel Clang  │ XPASS  │ Feature/HLSLLib/reversebits.16.test │
│ 18 │ 2025-11-28T20:04:28Z │ 19772907221 │ Windows Vulkan Intel Clang  │ XPASS  │ Feature/HLSLLib/reversebits.32.test │
│ 19 │ 2025-11-28T22:06:03Z │ 19774646176 │ Windows Vulkan QC Clang     │ XPASS  │ Feature/HLSLLib/reversebits.64.test │
│ 20 │ 2025-11-28T22:06:03Z │ 19774646176 │ Windows Vulkan QC Clang     │ XPASS  │ Feature/HLSLLib/reversebits.32.test │
│ 21 │ 2025-11-28T06:02:32Z │ 19755520578 │ Windows Vulkan NVIDIA Clang │ XPASS  │ Feature/HLSLLib/reversebits.32.test │
│ 22 │ 2025-11-28T06:02:32Z │ 19755520578 │ Windows Vulkan NVIDIA Clang │ XPASS  │ Feature/HLSLLib/reversebits.16.test │
│ 23 │ 2025-11-28T06:02:32Z │ 19755520578 │ Windows Vulkan NVIDIA Clang │ XPASS  │ Feature/HLSLLib/reversebits.64.test │
╰────┴──────────────────────┴─────────────┴─────────────────────────────┴────────┴─────────────────────────────────────╯

Before merging this PR, check/update the status of the issue tied with the original XFAILs: llvm/llvm-project#152049

@Icohedron Icohedron requested a review from kmpeng November 28, 2025 20:00
@Icohedron Icohedron added the test-all When applied to a PR this will opt-in to additional pre-merge test configurations.. label Nov 28, 2025
@Icohedron Icohedron changed the title Update XFAILs of reversebits tests Update XFAILs of reversebits tests for Vulkan Nov 28, 2025
kmpeng
kmpeng approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@kmpeng kmpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also closed llvm/llvm-project#152049 with a link to the PR that fixed it.

@Icohedron Icohedron merged commit 8bc4329 into llvm:main Dec 1, 2025
12 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogner bogner bogner approved these changes

@kmpeng kmpeng kmpeng approved these changes

Assignees

No one assigned

Labels

test-all When applied to a PR this will opt-in to additional pre-merge test configurations..

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Icohedron @bogner @kmpeng