From ab62f78f5ce07eda6c561b89901b4ac01f2704dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Kry=C5=A1p=C3=ADn?= Date: Mon, 26 Jun 2023 14:54:34 +0200 Subject: [PATCH] BREAKING CHANGE(web-twig): Remove `onClick` prop #DS-686 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Migration Guide Instead of the `onClick` prop, use native `onclick` in the `Button`, `ButtonLink`, `HeaderLink`, `HeaderDialogLink` and `Link` components. - ` + + diff --git a/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerDialogLink.twig__1.html b/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerDialogLink.twig__1.html index c4ba84bd0f..ef60342d7e 100644 --- a/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerDialogLink.twig__1.html +++ b/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerDialogLink.twig__1.html @@ -8,6 +8,6 @@ Job offers Job offers - Job offers + Job offers diff --git a/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerLink.twig__1.html b/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerLink.twig__1.html index 34b12353f1..5239e31604 100644 --- a/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerLink.twig__1.html +++ b/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set headerLink.twig__1.html @@ -8,6 +8,6 @@ Job offers Job offers - Job offers + Job offers diff --git a/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set linkDefault.twig__1.html b/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set linkDefault.twig__1.html index 9e47702eb7..cf5342fb21 100644 --- a/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set linkDefault.twig__1.html +++ b/packages/web-twig/tests/__snapshots__/ComponentsSnapshotTest__test with data set linkDefault.twig__1.html @@ -8,6 +8,6 @@ Example link Example link Example link - Example link + Example link diff --git a/packages/web-twig/tests/components-fixtures/buttonWithMainProps.twig b/packages/web-twig/tests/components-fixtures/buttonWithMainProps.twig index 0fd8bd1d84..fdc0574f4c 100644 --- a/packages/web-twig/tests/components-fixtures/buttonWithMainProps.twig +++ b/packages/web-twig/tests/components-fixtures/buttonWithMainProps.twig @@ -1,9 +1,9 @@ {% set onClickCallback = "alert('\" test')" %} - + {% set onClickAppend = "document.body.append('hello there'); return false;" %} - + diff --git a/packages/web-twig/tests/components-fixtures/headerDialogLink.twig b/packages/web-twig/tests/components-fixtures/headerDialogLink.twig index 8a653e7a83..b8a3bf071f 100644 --- a/packages/web-twig/tests/components-fixtures/headerDialogLink.twig +++ b/packages/web-twig/tests/components-fixtures/headerDialogLink.twig @@ -11,7 +11,7 @@ Job offers diff --git a/packages/web-twig/tests/components-fixtures/headerLink.twig b/packages/web-twig/tests/components-fixtures/headerLink.twig index aed8d69a0a..73d3f54487 100644 --- a/packages/web-twig/tests/components-fixtures/headerLink.twig +++ b/packages/web-twig/tests/components-fixtures/headerLink.twig @@ -11,7 +11,7 @@ Job offers diff --git a/packages/web-twig/tests/components-fixtures/linkDefault.twig b/packages/web-twig/tests/components-fixtures/linkDefault.twig index f3033e11d7..c0aa1b77c2 100644 --- a/packages/web-twig/tests/components-fixtures/linkDefault.twig +++ b/packages/web-twig/tests/components-fixtures/linkDefault.twig @@ -17,7 +17,7 @@ href="https://spirit.design" isDisabled isUnderlined - onClick="console.log('Hello!');" + onclick="console.log('Hello!');" target="_blank" title="test title" >