Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH-30764 Remove Creds from Nuget.Config #11

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@ jobs:
- name: Test Samples
run: dotnet test --no-restore --verbosity normal ./samples/MyCRM.Lodgement.Sample.Tests/MyCRM.Lodgement.Sample.Tests.csproj
- name: Build Docker image
run: docker build . -f ./samples/MyCRM.Lodgement.Sample/Dockerfile -t lodgementsample:latest
run: |
echo ${{secrets.LOAN_MARKET_TOKEN_READ_ONLY }}> ./nugetLoginToken.secret
docker build . -f ./samples/MyCRM.Lodgement.Sample/Dockerfile -t lodgementsample:latest --secret id=NUGET_LOGIN_TOKEN,src=./nugetLoginToken.secret
- name: Save Docker image to file
run: docker save lodgementsample:latest -o lodgementsample-docker-image.tar
- name: Save Docker image as an artifact
uses: actions/upload-artifact@v3
with:
name: lodgementsample-docker-image
path: lodgementsample-docker-image.tar
path: lodgementsample-docker-image.tar

2 changes: 2 additions & 0 deletions samples/MyCRM.Lodgement.Sample/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ RUN dotnet publish \
--configuration Release \
--output "/app/publish"



FROM mcr.microsoft.com/dotnet/aspnet:8.0-bookworm-slim AS final
WORKDIR /app
COPY --from=build /app/publish .
Expand Down
7 changes: 1 addition & 6 deletions samples/NuGet.Config
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,7 @@
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
<add key="lmgithubnuget" value="https://nuget.pkg.github.com/loanmarket/index.json" />
</packageSources>
<packageSourceCredentials>
<lmgithubnuget>
<add key="Username" value="license.admin@loanmarket.com.au" />
<add key="ClearTextPassword" value="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" />
</lmgithubnuget>
</packageSourceCredentials>

<packageSourceMapping>
<packageSource key="nuget.org">
<package pattern="*" />
Expand Down
Loading