Fix issue with frequency_sp being ignored #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmloose
reviewed
Mar 20, 2024
bdsf/collapse.py
Outdated
| # others have weight of 0. The init_freq_collapse function will then | ||
| # select the intended frequency | ||
| c_list = img.opts.collapse_av | ||
| if c_list == []: |
There was a problem hiding this comment.
I would prefer to write this as: if not c_list:
There was a problem hiding this comment.
Good suggestion. In fact, I see now that much of the new code I added is redundant, as many of the same things are done a bit earlier. So I removed some of the new stuff and refactored the existing code a bit.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue described in #218, where the value of the
frequency_spoption was ignored during the collapse of the image channels.