Fix issue that occurred when checking for the presence of SED fits in show_fit #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmloose
reviewed
Nov 15, 2024
Comment on lines
+367
to
+384
| # if i == index_first_waveplot: | ||
| # for j in range(len(j_with_gaus)): | ||
| # cmd = 'ax' + str(j+i+1) + ' = pl.subplot(' + str(numx) + \ | ||
| # ', ' + str(numy) + ', ' + str(j+i+1) + ', sharex=ax1, '+\ | ||
| # 'sharey=ax1)' | ||
| # exec(cmd) | ||
| # pl.title('Pyramidal Sources for\nWavelet Scale J = ' + | ||
| # str(j_with_gaus[j])) | ||
| # for pyr in img.pyrsrcs: | ||
| # for iisl, isl in enumerate(pyr.islands): | ||
| # jj = pyr.jlevels[iisl] | ||
| # jindx = j_with_gaus.index(jj) | ||
| # col = colours[pyr.pyr_id % 6] | ||
| # ind = N.where(~isl.mask_active) | ||
| # cmd = "ax" + str(jindx + index_first_waveplot + 1) + \ | ||
| # ".plot(ind[0]+isl.origin[0], "\ | ||
| # "ind[1]+isl.origin[1], '.', color=col)" | ||
| # exec(cmd) |
There was a problem hiding this comment.
Any reason to keep this code while it's commented?
There was a problem hiding this comment.
No, just to make it easier to add the functionality in case we decide to. I must say though that that is probably quite unlikely, as I've never heard anyone express an interest in the pyramidal source stuff (and I think it would be a fair bit of work to get it all working).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #220. Some cleanup of the code was also done.