Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup visualizations #147

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

mejarrett
Copy link

@mejarrett mejarrett commented Feb 28, 2020

This prevents the shards failed, too_many_buckets_exception errors on visualizations that we know may return over 10,000 buckets (typically seen with the time picker set to the last 2 hours, or longer). We also removed a duplicated visualization (Top-10-Dest-Ports-By-Flow-Count) in favor of Top-10-Dest-Ports-(pie).

Changes:

  • Removed the Top-10-Dest-Ports-By-Flow-Count visualization

  • Error prevention: On the Destination Port Dashboard and Replayed Traffic Dashboard, the Top 10 Dest Ports (Pie) donut chart has been reduced to two rings showing the top 10 destination ports and the top 10 applications on each port. The source and destination IP addresses are still available in the Ports Table at the bottom of the page.

  • Error prevention: We removed Sum of Repeated Field Count by Application on the Traffic Profile dashboard. In the past, this was interesting troubleshooting information (not useful to users as far as we know) because we used to insert every value on a repeated field into ES, so high repeated field count could cost us a lot of metadata space. Since we now truncate repeated fields over X length prior to insert, this is no longer useful for troubleshooting.

@@ -1,6 +1,6 @@
{
"migrationVersion": {
"visualization": "7.2.0"
"visualization": "7.4.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did all of these change to 7.4.2? Those changes seem like they should be reverted.

@@ -1,6 +1,6 @@
{
"migrationVersion": {
"dashboard": "7.0.0"
"dashboard": "7.3.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one is 7.3.0 for some reason?

@craig-cogdill
Copy link

Approved changes after Slack discussion, but I have not built or tested this.

Copy link

@Schatzman Schatzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested 👍

@josh-cogdill josh-cogdill merged commit 3cd8aa7 into logrhythm:7.5.2_NM Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants