Feat: improved error handling/logging/unwraping #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
kares
changed the title
similar to how we did for Beats
kares
force-pushed
the
logging-ssl-cause
branch
from
ffabfb3
to
e53d5d3
Compare
kaisecheng
pushed a commit
to kaisecheng/logstash-input-http
that referenced
this pull request
Jun 8, 2021
The unwrapping at the Java level is for exceptions wrapped by Netty. Full exception details will be logged at debug level from the Java side - since we seem to prefer (manual) exception logging at the plugin level. We also make sure to log cause, if any, on the Ruby side which now catches all (expected) Java exceptions. resolves logstash-plugins#134
kaisecheng
pushed a commit
to kaisecheng/logstash-input-http
that referenced
this pull request
Jun 8, 2021
The unwrapping at the Java level is for exceptions wrapped by Netty. Full exception details will be logged at debug level from the Java side - since we seem to prefer (manual) exception logging at the plugin level. We also make sure to log cause, if any, on the Ruby side which now catches all (expected) Java exceptions. resolves logstash-plugins#134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~ same as logstash-plugins/logstash-input-beats#405 :
while also aligns with improvements done previously add beats'
resolves #134