also clone default codec #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see a few failures of builds timing out, but that is happening in master as well. |
|
@jsvd is certainly not related, but I'll restart it anyway to see. |
|
so yeah, still failing. I am confident these are not related so will go ahead and merge. - I am another Pr incoming for calling flush so I will defer the publishing to the next PR. |
This was referenced Mar 22, 2018
Merged
Merged
|
this has been released in v3.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79
This PR simply support also cloning the default codec. The current specs does test the codec support so I do not believe more specs are required for this specific case which result in a thread safety issue and is hard to test per-se.