Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shutdown sequence to use plugin.stop #11

Closed
jsvd opened this issue Sep 11, 2015 · 0 comments
Closed

refactor shutdown sequence to use plugin.stop #11

jsvd opened this issue Sep 11, 2015 · 0 comments
Assignees
@guyboertje
Labels
shutdown semantics

Comments

@jsvd
Copy link
Member

jsvd commented Sep 11, 2015

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895
@jsvd jsvd mentioned this issue Sep 11, 2015
Closed
43 tasks
@guyboertje guyboertje mentioned this issue Sep 15, 2015
Closed
guyboertje added a commit to guyboertje/logstash-input-snmptrap that referenced this issue Sep 23, 2015
@guyboertje
Shutdown semantics: Add stop method and shared_example
80afc51 
add it_behaves_like "an interruptible input plugin" shared example
refactor plugin slightly

make error handling sleep stoppable

use Stud.stoppable_sleep

remove super call in stop

fix question mark typo

add plain codec dep to gemspec

closes logstash-plugins#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyboertje guyboertje

Labels
shutdown semantics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsvd @guyboertje @suyograo