refactor plugin shutdown

[colinsurprenant]

refactor for the new shutdown semantic.

note that the specs were not refactored as a whole be new specs were added, using the new style, based on the udp input specs. some TODOs have been commented to note some duplicate code and DRYing that we could do in a followup issue/PR.

[talevy]

not needed anymore, right?

[andrewvc]

Have you considered extracting this block into a separate method?

[colinsurprenant]

It could I guess, and a lot of code could be better refactored here too. tried to keep it to minimal.

[andrewvc]

Are these specs passing for you @colinsurprenant ? I'm currently seeing them hang indefinitely.

The code looks alright otherwise.

[colinsurprenant]

is it running agaist the lastest core code base? I've run the tests in a loop to catch potential timing issues and it always passed... weird.

[andrewvc]

This spec is where it hangs for me

[andrewvc]

@colinsurprenant It hangs for me here https://github.com/logstash-plugins/logstash-input-tcp/pull/8/files#r40319932

This is running of 2.0.0.snapshot2. Is there another ref I should be basing this off of?

[andrewvc]

Running with --debug I get it repeating the INFLIGHT EVENTS REPORT message

Accepted connection {:client=>"127.0.0.1:62233", :server=>"0.0.0.0:48607", :level=>:debug, :file=>"logstash/inputs/tcp.rb", :line=>"177", :method=>"block in server_connection_thread"}
config LogStash::Codecs::Line/@charset = "UTF-8" {:level=>:debug, :file=>"logstash/config/mixin.rb", :line=>"111", :method=>"block in config_init"}
stopping {:plugin=><LogStash::Inputs::Tcp port=>48607, debug=>false, codec=><LogStash::Codecs::Line charset=>"UTF-8">, host=>"0.0.0.0", data_timeout=>-1, mode=>"server", ssl_enable=>false, ssl_verify=>false, ssl_key_passphrase=><password>>, :level=>:debug, :file=>"logstash/inputs/base.rb", :line=>"115", :method=>"do_stop"}
["INFLIGHT_EVENTS_REPORT", "2015-09-24T08:45:33-05:00", {"input_to_filter"=>0, "filter_to_output"=>0, "outputs"=>[]}] {:level=>:warn, :file=>"logstash/util/reporter.rb", :line=>"26", :method=>"report"}
["INFLIGHT_EVENTS_REPORT", "2015-09-24T08:45:33-05:00", {"input_to_filter"=>0, "filter_to_output"=>0, "outputs"=>[]}] {:level=>:warn, :file=>"logstash/util/reporter.rb", :line=>"26", :method=>"report"}

That's where it hangs

[andrewvc]

@colinsurprenant AHA. I was running the specs against JRuby 9.0.0.0 . It worked when I switched to 1.7.20 .

In that case LGTM, but that does not bode well for the future. Any ideas why?

[colinsurprenant]

@andrewvc lots have changed IO wise in 9k, we'll have to investigate. Note that we should certainly test against 9k and report problems in JRuby if we find them. OTOH 9k is definitely not mature enough to consider it for a release soon.

[jsvd]

LGTM, tests passed, tested manually server/client without ssl, everything worked.

[colinsurprenant]

squashed, merging.