Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shutdown sequence to use plugin.stop #3

Closed
jsvd opened this issue Sep 11, 2015 · 0 comments
Closed

refactor shutdown sequence to use plugin.stop #3

jsvd opened this issue Sep 11, 2015 · 0 comments
Assignees
@guyboertje
Labels
shutdown semantics

Comments

@jsvd
Copy link
Member

jsvd commented Sep 11, 2015

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyboertje guyboertje

Labels
shutdown semantics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR for Refactor shutdown sequence to use plugin.stop guyboertje/logstash-input-xmpp
4 participants
@jsvd @guyboertje @talevy @suyograo