Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws sdk v3 #9

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Use aws sdk v3 #9

merged 1 commit into from
Jun 28, 2022

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jun 23, 2022

Introduce aws-sdk v3, by including the service-specific gems + aws-sdk-core v3, instead of adding the top level ask-sdk gem that would bring on > 300 dependencies.

This PR also removes the calls to eager loading as in aws-sdk v3 it's no longer necessary since we're loading the gems we need explicitly.

Replacement of #6 that was closed by github once bootstrap_work branch was deleted.

@jsvd jsvd requested a review from robbavey June 23, 2022 11:14
@jsvd jsvd force-pushed the use_aws_sdk_v3 branch from 4d5a7bb to 80cdd69 Compare June 23, 2022 11:21
* introduce individual aws gems as dependencies
* no more eager_autoload
@jsvd jsvd force-pushed the use_aws_sdk_v3 branch from 80cdd69 to 80b77f3 Compare June 23, 2022 11:22
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants