remove finished from teardown #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
|
LGTM |
|
I know this is somewhat out of scope for this PR but can you also rename teardown to close? |
|
@jsvd Done, renamed #teardown -> #close |
| @@ -54,7 +54,7 @@ def receive(event) | |||
| close_stale_pipes | |||
| end # def receive | |||
|
|
|||
| def teardown | |||
| def close | |||
| @logger.info("Teardown: closing pipes") | |||
ph
force-pushed
the
fix/remove-finished
branch
from
7fc2e93
to
5dae2bb
Compare
|
yes, rebased too. |
|
LGTM |
|
Merged sucessfully into master! |
ph
added a commit
that referenced
this pull request
Sep 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref elastic/logstash#3813