Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds lowercase to TZ pattern #230

Closed
wants to merge 1 commit into from
Closed

adds lowercase to TZ pattern #230

wants to merge 1 commit into from

Conversation

Rock-HOG
Copy link

some log entries may show lowercase timezone.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

some log entries may show lowercase timezone.
@Rock-HOG
Copy link
Author

I have signed the CLA.

Thanks

@jsvd
Copy link
Member

jsvd commented Jun 5, 2018

would you mind adding tests for this change? there are many examples of tests in the spec/ folder

@kares
Copy link
Contributor

kares commented Jul 9, 2020

Thanks for the PR, seems like this has been stale for a while.
Since the PR was opened a discussion went on at #172.

Lower-case names seem quite uncommon and instead the issue focuses on matching more time-zones.
I know Ruby would match such strings but that is more of an implementation detail I believe than an actual intent.
Going to close this one in favour of #235, if anyone is seeing lower-case TZ identifiers produced please let us know more details (sample logs) on what kind of apps/services produce them.

@kares kares closed this Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants