From 3572d05aeb32538f87bf31427f81a2b7452ebb13 Mon Sep 17 00:00:00 2001
From: Gao Sun <gao@silverhand.io>
Date: Mon, 4 Jul 2022 22:32:10 +0800
Subject: [PATCH] fix(console): save sie when secondary method is disabled

---
 .../SignInExperience/components/SignInMethodsForm.tsx     | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages/console/src/pages/SignInExperience/components/SignInMethodsForm.tsx b/packages/console/src/pages/SignInExperience/components/SignInMethodsForm.tsx
index 88a954b1c01..cc7ef30f47b 100644
--- a/packages/console/src/pages/SignInExperience/components/SignInMethodsForm.tsx
+++ b/packages/console/src/pages/SignInExperience/components/SignInMethodsForm.tsx
@@ -76,7 +76,7 @@ const SignInMethodsForm = () => {
           </div>
         );
       }),
-    [primaryMethod, register, t, email, social, sms]
+    [t, primaryMethod, email, sms, social, control]
   );
 
   return (
@@ -116,7 +116,11 @@ const SignInMethodsForm = () => {
       )}
       <FormField title="admin_console.sign_in_exp.sign_in_methods.enable_secondary">
         <Switch
-          {...register('signInMethods.enableSecondary', { required: true })}
+          /**
+           * DO NOT SET THIS FIELD TO REQUIRED UNLESS YOU KNOW WHAT YOU ARE DOING.
+           * https://github.com/react-hook-form/react-hook-form/issues/2323
+           */
+          {...register('signInMethods.enableSecondary')}
           label={t('sign_in_exp.sign_in_methods.enable_secondary_description')}
         />
       </FormField>