Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "macOS: install Meson and Ninja via Homebrew (#163)" #167

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

kleisauke
Copy link
Collaborator

@kleisauke kleisauke commented Nov 13, 2022

This reverts commit 944fbd2 and avoids depending on Python from Homebrew. The mentioned GitHub actions runner issue in PR #163 is probably a duplicate of actions/runner-images#6507, which was fixed with commit actions/runner-images@f6632ff , but not yet deployed at the time of writing.

This PR is marked as a draft until GitHub updates its macOS runner images. After that, we can drop the workaround added in commit 27703f9.

@lovell
Copy link
Owner

lovell commented Nov 14, 2022

Thanks, my understanding is the runner images are updated approximately once per week, so yes, let's wait.

@kleisauke
Copy link
Collaborator Author

GitHub actions has rolled out its macos-11 image containing commit actions/runner-images@f6632ff.

This is ready for review now.

@kleisauke kleisauke marked this pull request as ready for review December 2, 2022 10:06
@lovell lovell merged commit 4a0cf43 into lovell:main Dec 2, 2022
@lovell
Copy link
Owner

lovell commented Dec 2, 2022

Excellent, thank you Kleis.

@kleisauke kleisauke deleted the revert-pr-163 branch December 2, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants