Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add f64 type and repeated field mode support in AppendRows API #112

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

imor
Copy link
Contributor

@imor imor commented Nov 5, 2024

This PR does two things:

  1. Fixes null being inserted for f64 types. See this comment for details about the fix: Unable to write double/f64 on float columns using the Storage Write API #106 (comment)
  2. Adds support for repeated field mode.

Since this is a breaking change a new minor version bumped crate needs to be published.

@imor imor marked this pull request as ready for review November 11, 2024 10:47
@imor imor changed the title add f64 support in append_rows add f64 type and repeated field mode support in AppendRows API Nov 11, 2024
Copy link
Owner

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I will wait the second PR discussed in the other thread (#106) to publish a new version

@lquerel lquerel merged commit 2adaf4d into lquerel:main Nov 17, 2024
2 of 3 checks passed
@lquerel
Copy link
Owner

lquerel commented Jan 12, 2025

FYI, the version 0.25.0 (including your PR) has been published on crates.io. Thanks

@imor imor deleted the fix-type-mapping branch January 13, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to write double/f64 on float columns using the Storage Write API
2 participants