Update to z2jh 2.0.0/JH 3.0.0 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
This looks fine; is there anything else we need to pin besides jupyterhub? I feel like we keep discovering there are other packages that should have lockstep versions, but then not writing down which ones they are. Does jupyterhub-kubespawner do independent releases with unrelated version numbers?
|
I think we can take the latest release of jupyterhub-kubespawner. I didn't do anything but rebuild the container (well, I need the z2jh.py from 2.0.0, which won't be replaced until we actually sync the whole app, because Mapping moves from collections to collections.abc), and it seems to work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.