DM-45993: Optimize DirectButlerCollections.query_info to avoid too many queries #1075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct butler reimplements
query_info
method to avoid multiple queries, which makes it significantly faster. This patch also adds two optional parameters toquery_info
to allow further optimizations. There is still an inefficiency infetch_summaries
method when the number of potential collections is very large (when collections are*
). Further optimization would probably need more work (and I think that we'll have to optimize it as the number of collections grows every day).@dhirving, I added the same parameters to remote butler interface, but they are not used for now. I know you are working on DM-46129, maybe you can add forwarding of those parameters to remote server?
Checklist
doc/changes
configs/old_dimensions