Skip to content

Commit

Permalink
Add an extensions API endpoint for downloading signatures
Browse files Browse the repository at this point in the history
closes pulp#504
  • Loading branch information
lubosmj committed Jan 10, 2022
1 parent f5f00ac commit fd7e098
Show file tree
Hide file tree
Showing 5 changed files with 61 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES/504.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added an extensions API endpoint for downloading image signatures.
46 changes: 45 additions & 1 deletion pulp_container/app/registry_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,12 @@ def default_response_headers(self):
Provide common headers to all responses.
"""
headers = super().default_response_headers
headers.update({"Docker-Distribution-Api-Version": "registry/2.0"})
headers.update(
{
"Docker-Distribution-Api-Version": "registry/2.0",
"X-Registry-Supports-Signatures": "1",
}
)
return headers

def get_exception_handler_context(self):
Expand Down Expand Up @@ -970,3 +975,42 @@ def receive_artifact(self, chunk):
artifact = Artifact.objects.get(sha256=artifact.sha256)
artifact.touch()
return artifact


class Signatures(ContainerRegistryApiMixin, ViewSet):
"""A ViewSet for image signatures."""

lookup_value_regex = "sha256:[0-9a-f]+"

def head(self, request, path, pk=None):
"""Respond to HEAD requests querying signatures by sha256."""
return self.get(request, path, pk=pk)

def get(self, request, path, pk):
"""Return a signature identified by its sha256 checksum."""
distribution, _, repository_version = self.get_drv_pull(path)

try:
manifest = models.Manifest.objects.get(digest=pk)
except models.Manifest.DoesNotExit:
raise ManifestNotFound(reference=pk)

signatures = models.ManifestSignature.objects.filter(
signed_manifest=manifest, pk__in=repository_version.content
)

return Response(self.get_response_data(signatures))

@staticmethod
def get_response_data(signatures):
"""Extract version, type, name, and content from the passed signature data."""
data = []
for signature in signatures:
signature = {
"version": 2,
"type": signature.type,
"name": signature.name,
"content": signature.data.tobytes().decode(),
}
data.append(signature)
return {"signatures": data}
2 changes: 2 additions & 0 deletions pulp_container/app/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
BlobUploads,
CatalogView,
Manifests,
Signatures,
TagsListView,
VersionView,
)
Expand All @@ -25,6 +26,7 @@
router.register(r"^v2/(?P<path>.+)/blobs/uploads\/?", BlobUploads, basename="docker-upload")
router.register(r"^v2/(?P<path>.+)/blobs", Blobs, basename="blobs")
router.register(r"^v2/(?P<path>.+)/manifests", Manifests, basename="manifests")
router.register(r"^extensions/v2/(?P<path>.+)/signatures", Signatures, basename="signatures")

urlpatterns = [
path("token/", BearerTokenView.as_view()),
Expand Down
3 changes: 3 additions & 0 deletions pulp_container/app/webserver_snippets/apache.conf
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
ProxyPass /v2 ${pulp-api}/v2
ProxyPassReverse /v2 ${pulp-api}/v2

ProxyPass /extensions/v2 ${pulp-api}/extensions/v2
ProxyPassReverse /extensions/v2 ${pulp-api}/extensions/v2

ProxyPass /pulp/container ${pulp-content}/pulp/container
ProxyPassReverse /pulp/container ${pulp-content}/pulp/container

Expand Down
10 changes: 10 additions & 0 deletions pulp_container/app/webserver_snippets/nginx.conf
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ location /v2/ {
client_max_body_size 0;
}

location extensions/v2/ {
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header Host $http_host;
# we don't want nginx trying to do something clever with
# redirects, we set the Host: header above already.
proxy_redirect off;
proxy_pass http://pulp-api;
}

location /pulp/container/ {
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Proto $scheme;
Expand Down

0 comments on commit fd7e098

Please sign in to comment.