Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return error on SendMessage when session is closed #3218

Merged

Conversation

mengelbart
Copy link
Contributor

Returns the error from AddAndWait to the user of SendMessage e.g. when the session is closed.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #3218 (75d2276) into master (e9d12b7) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage   85.40%   85.41%   +0.01%     
==========================================
  Files         134      134              
  Lines        9825     9824       -1     
==========================================
  Hits         8391     8391              
+ Misses       1060     1059       -1     
  Partials      374      374              
Impacted Files Coverage Δ
session.go 77.53% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d12b7...75d2276. Read the comment docs.

@marten-seemann
Copy link
Member

Thank you!

@marten-seemann marten-seemann changed the title Return error on SendMessage when session is closed return error on SendMessage when session is closed Jun 28, 2021
@marten-seemann marten-seemann merged commit 8b7e43e into quic-go:master Jun 28, 2021
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants