reduce allocations of ackhandler.Packet #3525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a 1 GB transfer, quic-go allocates 500 MB on the sending side, as determined using the
allocs
function of pprof. Of those 500 MB, 140 MB are consumed for theackhandler.Packet
. With this change, we can bring this down to 25 MB.We can easily solve this by:
Packet
by pointer instead of by value in the linked lists used in the ackhandlersync.Pool
to reusePacket
structsBefore:
After: