Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split code paths for packing 0-RTT and 1-RTT packets in packet packer #3540

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

marten-seemann
Copy link
Member

Part of #3526.

Combined with #3534 this will allow us to pack short header packets without allocation a header struct first, we can just serialize the short header into the buffer directly, saving tons of allocations.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 85.55% // Head: 85.55% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c1513d9) compared to base (7023b52).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
- Coverage   85.55%   85.55%   -0.00%     
==========================================
  Files         137      137              
  Lines       10086    10083       -3     
==========================================
- Hits         8629     8626       -3     
  Misses       1080     1080              
  Partials      377      377              
Impacted Files Coverage Δ
packet_packer.go 84.49% <85.71%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit 93e1d03 into master Aug 30, 2022
@marten-seemann marten-seemann deleted the split-0rtt-1rtt-packing-code-paths branch September 1, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants