Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify packing of ACK-only packets #3545

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

marten-seemann
Copy link
Member

Depends on #3544.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 85.50% // Head: 85.59% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (818768d) compared to base (c57ea6f).
Patch coverage: 82.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
+ Coverage   85.50%   85.59%   +0.10%     
==========================================
  Files         138      138              
  Lines       10254    10218      -36     
==========================================
- Hits         8767     8746      -21     
+ Misses       1103     1091      -12     
+ Partials      384      381       -3     
Impacted Files Coverage Δ
connection.go 76.53% <50.00%> (-0.56%) ⬇️
packet_packer.go 87.77% <100.00%> (+3.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit 2b54aea into master Sep 9, 2022
@marten-seemann marten-seemann deleted the simplify-ack-only-packing branch October 9, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants