Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename destroy_all -> truncate #110

Closed
paulcsmith opened this issue Jun 21, 2019 · 1 comment · Fixed by #134
Closed

Rename destroy_all -> truncate #110

paulcsmith opened this issue Jun 21, 2019 · 1 comment · Fixed by #134
Labels
clarify api Rename/remove/add something to make the API easier to understand
Milestone
Avram next

Comments

@paulcsmith
Copy link
Member

paulcsmith commented Jun 21, 2019 •
edited
Loading

Because that's what it does

Also it should be a class method because it ignores any other where clauses
@paulcsmith paulcsmith mentioned this issue Jun 21, 2019
Merged
@jwoertink
Copy link
Member

I like that.

@paulcsmith paulcsmith mentioned this issue Jun 21, 2019
Closed
@jwoertink jwoertink added the clarify api Rename/remove/add something to make the API easier to understand label Jun 27, 2019
@paulcsmith paulcsmith added this to the Avram next milestone Jul 2, 2019
@paulcsmith paulcsmith assigned paulcsmith and unassigned paulcsmith Jul 2, 2019
@jwoertink jwoertink mentioned this issue Jul 3, 2019
Merged
paulcsmith pushed a commit that referenced this issue Jul 3, 2019
@jwoertink @paulcsmith
renamed destroy_all to truncate. (#134)
428158f 
* renamed destroy_all to truncate. fixes #110

* make truncate a class method since it's not chainable like other instance methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarify api Rename/remove/add something to make the API easier to understand
Projects
None yet
Milestone
Avram next
Development

Successfully merging a pull request may close this issue.

renamed destroy_all to truncate.
2 participants
@jwoertink @paulcsmith