Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for numeric values #537

Closed
matthewmcgarvey opened this issue Nov 17, 2020 · 0 comments · Fixed by #580
Closed

Add validation for numeric values #537

matthewmcgarvey opened this issue Nov 17, 2020 · 0 comments · Fixed by #580
Assignees
@matthewmcgarvey

Comments

@matthewmcgarvey
Copy link
Member

The lack of a numeric validation and the presence of validate_size_of causes confusion on how to validate numbers.

At the very least it should have a min and max field.

Ex: validate_numeric inventory_count, min: 0, allow_nil: false

Related: https://github.com/luckyframework/lucky/issues/1308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmcgarvey matthewmcgarvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation for numbers matthewmcgarvey/avram
1 participant
@matthewmcgarvey