-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing spec on crystal 0.36 #1399
Comments
Is the proper fix to change the test to look for a space, or to change the template code to remove the space? A single space between tags in HTML often changes the way things work/look, so this could be a breaking change if we change the tag method generation. |
Good question. Since these are self-closing tags, the space won't matter. Like |
@jwoertink Can I create a PR for this issue? |
@96RadhikaJadhav That'd be great! |
Completed by #1400 |
#1398 (comment)
I left some notes on that issue. Just need to remove the space at the end of this https://github.com/luckyframework/lucky/blob/master/src/lucky/tags/base_tags.cr#L75
The text was updated successfully, but these errors were encountered: