Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing spec on crystal 0.36 #1399

Closed
jwoertink opened this issue Jan 25, 2021 · 5 comments
Closed

Failing spec on crystal 0.36 #1399

jwoertink opened this issue Jan 25, 2021 · 5 comments

Comments

@jwoertink
Copy link
Member

#1398 (comment)

I left some notes on that issue. Just need to remove the space at the end of this https://github.com/luckyframework/lucky/blob/master/src/lucky/tags/base_tags.cr#L75

@robacarp
Copy link
Contributor

Is the proper fix to change the test to look for a space, or to change the template code to remove the space? A single space between tags in HTML often changes the way things work/look, so this could be a breaking change if we change the tag method generation.

@jwoertink
Copy link
Member Author

Good question. Since these are self-closing tags, the space won't matter. Like <br /> <br /> will look the same as <br /><br />. Plus any space used for rendering should be on the user, I think. So for this change, we can just remove the space in the code.

@96RadhikaJadhav
Copy link
Contributor

@jwoertink Can I create a PR for this issue?

@matthewmcgarvey
Copy link
Member

@96RadhikaJadhav That'd be great!

@matthewmcgarvey
Copy link
Member

Completed by #1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants