Change collections import to collections.abc #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for no Iterable in Collections since Python 3.10 removed the backward compatibility. Collections.abc available since 3.3 so no fallback needed (this plugin targets 3.5+)
|
Thanks for your PR! I've just released v2.5.1 with this fix. |
markmc
added a commit
to markmc/gateway-api
that referenced
this pull request
Feb 14, 2022
See lukasgeiter/mkdocs-awesome-pages-plugin#49 mkdocs-awesome-pages-plugin 2.5.1 contains the fix, but 2.7.0 is the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for no Iterable in Collections since Python 3.10 removed the backward compatibility. Collections.abc available since 3.3 so no fallback needed (this plugin targets 3.5+)
No movement on #47 for a week so here is the fix. Would love to use this plugin in CI but need it to be updated.