Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add createEffect method from the lume's Element3D #11

Open
trusktr opened this issue Feb 29, 2024 · 0 comments
Open

add createEffect method from the lume's Element3D #11

trusktr opened this issue Feb 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@trusktr
Copy link
Member

trusktr commented Feb 29, 2024

this.createEffect() will make an effect that is conveniently stopped in disconnectedCallback. This is useful for creating effects in connectedCallback and then not having to use createRoot and disconnectedCallback to stop them.

Currently:

connectedCallback() {
  super.connectedCallback()
  
  createRoot(dispose => {
    this.dispose = dispose
    createEffect(() => {
      // ...
      onCleanup(() => {...})
    })
  })
}

disconnectedCallback() {
  super.disconnectedCallback()
  this.dispose()
}

Using this.createEffect:

connectedCallback() {
  super.connectedCallback()
  
  this.createEffect(() => {
    // ...
    onCleanup(() => {...})
  })
}
@trusktr trusktr added the enhancement New feature or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant