Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API is missing CORS headers #8

Open
Durss opened this issue Mar 6, 2024 · 1 comment
Open

API is missing CORS headers #8

Durss opened this issue Mar 6, 2024 · 1 comment

Comments

@Durss
Copy link

Durss commented Mar 6, 2024

Hello!

Currently Lumia REST API lacks CORS headers.
It's an issue if we want to use it from a web app.

Browsers require CORS to accept connections from a given domain to allow it to connect to.
Browsers have other restrictions like cross-security stuff which technically would avoid a secured domain to connect with an unsecured one but on most browsers there's an exception on localhost/127.0.0.1 (except for some Safari and Brave if shield is enabled) so if CORS headers were added we could technically connect to Lumia API.

Basically it would be nice if Lumia was sending this in the response headers:
Access-Control-Allow-Origin: *

Have a good day :)

@ahadcove
Copy link
Member

ahadcove commented Mar 6, 2024

Access-Control-Allow-Origin: *

Ahh good catch, we'll add it to the next version. Beta may go out today for this for 7.5.3 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants