From cf7bc6135c232ae31e07528857e95c2531228ac5 Mon Sep 17 00:00:00 2001 From: enyan94 Date: Tue, 11 Dec 2018 13:43:20 -0800 Subject: [PATCH 1/4] tab nav. skips readonly denom --- app/src/renderer/components/governance/ModalPropose.vue | 1 + .../governance/__snapshots__/ModalPropose.spec.js.snap | 1 + 2 files changed, 2 insertions(+) diff --git a/app/src/renderer/components/governance/ModalPropose.vue b/app/src/renderer/components/governance/ModalPropose.vue index eb5d1c8343..17b79d46b6 100644 --- a/app/src/renderer/components/governance/ModalPropose.vue +++ b/app/src/renderer/components/governance/ModalPropose.vue @@ -53,6 +53,7 @@ id="denom" :placeholder="denom" type="text" + :tabindex="-1" readonly="readonly" /> From 6d5f0ba4af85a5770ae31b40803e9bad09dc0fde Mon Sep 17 00:00:00 2001 From: enyan94 Date: Tue, 11 Dec 2018 13:51:02 -0800 Subject: [PATCH 2/4] changelog msg --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ed884b77d7..386a7863b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -80,6 +80,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - [\#1638](https://github.com/cosmos/voyager/issues/1638) removed account password from the state and now user has to input it on every transaction @fedekunze - [\#1655](https://github.com/cosmos/voyager/issues/1655) Text and Textarea fields trimmed @sabau - [\#1686](https://github.com/cosmos/voyager/issues/1686) Changed proposals from array to object @sabau +- [\#1724](https://github.com/cosmos/voyager/issues/1724) set tabindex attribute to -1 for readonly denom. tab navgiation now skips element @enyan94 ### Fixed From cedfb0a540b7ffc547edf0cca83a38a898145b2a Mon Sep 17 00:00:00 2001 From: enyan94 Date: Tue, 11 Dec 2018 13:56:24 -0800 Subject: [PATCH 3/4] moving tabindex attrib above type, style change --- app/src/renderer/components/governance/ModalPropose.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/renderer/components/governance/ModalPropose.vue b/app/src/renderer/components/governance/ModalPropose.vue index 17b79d46b6..5d6f4e6311 100644 --- a/app/src/renderer/components/governance/ModalPropose.vue +++ b/app/src/renderer/components/governance/ModalPropose.vue @@ -52,8 +52,8 @@ Date: Thu, 13 Dec 2018 10:06:37 +0100 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 386a7863b9..4a9bd0978c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -80,7 +80,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - [\#1638](https://github.com/cosmos/voyager/issues/1638) removed account password from the state and now user has to input it on every transaction @fedekunze - [\#1655](https://github.com/cosmos/voyager/issues/1655) Text and Textarea fields trimmed @sabau - [\#1686](https://github.com/cosmos/voyager/issues/1686) Changed proposals from array to object @sabau -- [\#1724](https://github.com/cosmos/voyager/issues/1724) set tabindex attribute to -1 for readonly denom. tab navgiation now skips element @enyan94 +- [\#1724](https://github.com/cosmos/voyager/issues/1724) set tabindex attribute to -1 for readonly denom on ModalProposals. tab navgiation now skips element @enyan94 ### Fixed