Simplify local boot and enable multi node #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
sabau
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1751 +/- ##
=======================================
Coverage 97.7% 97.7%
=======================================
Files 102 102
Lines 2096 2096
Branches 93 93
=======================================
Hits 2048 2048
Misses 39 39
Partials 9 9
|
Codecov Report
@@ Coverage Diff @@
## develop #1751 +/- ##
===========================================
+ Coverage 97.7% 97.71% +<.01%
===========================================
Files 102 102
Lines 2096 2097 +1
Branches 93 93
===========================================
+ Hits 2048 2049 +1
Misses 39 39
Partials 9 9
|
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
faboweb
reviewed
Dec 17, 2018
|
Awesome :) |
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
…counts of the validators Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
…odes Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
…et' into sabau/1661-multinode-local-testnet
sabau
commented
Dec 18, 2018
| numberNodes | ||
| ) | ||
| await startNodes(nodes, mainAccountSignInfo, network) | ||
| fs.copySync(join(nodes[1].home, `config`), cliHomePrefix) |
There was a problem hiding this comment.
This mimic the behaviour of electron start, I tried hard not to put those three lines here and rely on that hook but I couldn't find a nice way of doing it. Any idea?
There was a problem hiding this comment.
From copySync to WriteFileSync should happen at boot in my mind, instead I'm forcing it to happen at network creation time (I didn't wanted to touch also that process right now, to keep this PR small)
There was a problem hiding this comment.
boot process will die anyway ;)
sabau
changed the title
faboweb
reviewed
Dec 18, 2018
| } | ||
|
|
||
| // nodes[0] is a placeholder just to be aligned with the enumeration used in gaia | ||
| // TODO: next PR refactor also gaia to simplify numeration |
faboweb
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karoly Albert Szabo szabo.karoly.a@gmail.com
Closes #1661
Description:
❤️ Thank you!
CHANGELOG.mdwith issue # and GitHub usernameFiles changedin the github PR explorer