Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle playback mode button in the player. #309

Closed
wants to merge 1 commit into from
Closed

Add toggle playback mode button in the player. #309

wants to merge 1 commit into from

Conversation

andylow
Copy link

@andylow andylow commented Sep 15, 2020

No description provided.

@lyswhut
Copy link
Owner

lyswhut commented Sep 16, 2020

Thank you for the PR, but this feature has been marked as enhanced, and I have completed the development, now I am waiting for others to design the icon ...😂
Now I need the following icons:

  • Desktop lyrics
    • Turn on
    • Turn off
  • Play mode switch
    • List play
    • List loop
    • Random list
    • Single loop
    • Disable(disable automatic switching to the next song)
  • Add the currently playing song to

A total of eight icons, can you provide me with the rest of the icons? Or later I will wait for others to design the icon, and then push the code to GitHub to release a new version

@andylow
Copy link
Author

andylow commented Sep 17, 2020

I see, good to know that.
Except the 4 icons there, I also have 3 more icons here, you can check it out whether there are suitable to use.
svg-icons.zip

However, I'm not sure what is "Add the currently playing song to".

@lyswhut
Copy link
Owner

lyswhut commented Sep 18, 2020

Thank you very much for the icon!
"Add the currently playing song to" is to add the currently playing song to my list.

I have now changed the lyrics icon to line style, This is what it looks like after rendering:
image

@andylow
Copy link
Author

andylow commented Sep 18, 2020

Awesome ! 👏🏻
I will close this PR :)

@andylow andylow closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants