-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for win-arm64
prebuilt binaries
#82
Comments
Unfortunately, it's not possible at the moment due to GitHub not providing a Windows arm64 runner. You can keep track of actions/runner-images#768 for updates. |
@m4heshd maybe I am doing something wrong but I was able to generate an arm64 build of better-sqlite3-multiple-cipher on my on x86/x64 Windows PC using Visual Studio ARM build tools. |
Just tested and this is technically possible now since Node has been providing Windows headers for I might add this feature but need to test it a lot before. I already tested all Electron versions and currently supported Node versions. Everything's fine except Node v18. |
That's good to know. In the meantime, I have forked this project since I need the ARM binaries for Electron quite urgently. I'll be keeping an eye out for when you release support for ARM builds so I can move back. |
PR already created for the upstream at WiseLibs/better-sqlite3#1141. You can take a look at the tests here: https://github.com/m4heshd/better-sqlite3-multiple-ciphers/actions/runs/7853495517 |
Thanks for the quick response! |
This feature is now available in v9.4.1. |
@m4heshd thank you for adding this so quickly! Would it also be possible to add support for linux-arm64 prebuilds for electron? |
We talked about that at BS3 but not feasible for the moment. It can be done, but due to the limitations of Qemu, it would take days for the workflow to finish if we do that. Have to wait for dedicated hardware. But who knows? This might be possible already 🤷🏻♂️. We just don't have enough time to put into research sadly. |
@m4heshd positive development in this area: https://github.blog/changelog/2024-06-03-actions-arm-based-linux-and-windows-runners-are-now-in-public-beta/ |
That is indeed great news. 🥳 |
No description provided.
The text was updated successfully, but these errors were encountered: