Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for win-arm64 prebuilt binaries #82

Closed
thecodrr opened this issue Feb 6, 2024 · 11 comments
Closed

Add support for win-arm64 prebuilt binaries #82

thecodrr opened this issue Feb 6, 2024 · 11 comments
Labels
enhancement 🌟 New feature or request Implemented ✅ This feature has been successfully implemented

Comments

@thecodrr
Copy link

thecodrr commented Feb 6, 2024

No description provided.

@m4heshd
Copy link
Owner

m4heshd commented Feb 6, 2024

Unfortunately, it's not possible at the moment due to GitHub not providing a Windows arm64 runner. You can keep track of actions/runner-images#768 for updates.

@m4heshd m4heshd closed this as completed Feb 6, 2024
@m4heshd m4heshd added wontfix 🚫 This will not be worked on third-party-issue This issue is related to a third-party library labels Feb 6, 2024
@thecodrr
Copy link
Author

@m4heshd maybe I am doing something wrong but I was able to generate an arm64 build of better-sqlite3-multiple-cipher on my on x86/x64 Windows PC using Visual Studio ARM build tools.

@m4heshd
Copy link
Owner

m4heshd commented Feb 10, 2024

Just tested and this is technically possible now since Node has been providing Windows headers for arm since Node v20, at https://nodejs.org/dist/v20.0.0. But builds will still fail for Node v18. Electron however provided arm headers since v6.0.8. So electron builds seem to be fine.

I might add this feature but need to test it a lot before. I already tested all Electron versions and currently supported Node versions. Everything's fine except Node v18.

@thecodrr
Copy link
Author

That's good to know.

In the meantime, I have forked this project since I need the ARM binaries for Electron quite urgently. I'll be keeping an eye out for when you release support for ARM builds so I can move back.

@m4heshd
Copy link
Owner

m4heshd commented Feb 10, 2024

PR already created for the upstream at WiseLibs/better-sqlite3#1141.

You can take a look at the tests here: https://github.com/m4heshd/better-sqlite3-multiple-ciphers/actions/runs/7853495517

@m4heshd m4heshd reopened this Feb 10, 2024
@m4heshd m4heshd added work-in-progress ⚙️ This feature/issue is currently being worked on blocked-by-upstream 🛑 This issue is waiting for a fix on a depending library and removed wontfix 🚫 This will not be worked on third-party-issue This issue is related to a third-party library labels Feb 10, 2024
@thecodrr
Copy link
Author

Thanks for the quick response!

@m4heshd
Copy link
Owner

m4heshd commented Feb 11, 2024

This feature is now available in v9.4.1.
Closing this.

@m4heshd m4heshd closed this as completed Feb 11, 2024
@m4heshd m4heshd added enhancement 🌟 New feature or request Implemented ✅ This feature has been successfully implemented and removed work-in-progress ⚙️ This feature/issue is currently being worked on blocked-by-upstream 🛑 This issue is waiting for a fix on a depending library labels Feb 11, 2024
@thecodrr
Copy link
Author

@m4heshd thank you for adding this so quickly! Would it also be possible to add support for linux-arm64 prebuilds for electron?

@m4heshd
Copy link
Owner

m4heshd commented Feb 13, 2024

We talked about that at BS3 but not feasible for the moment. It can be done, but due to the limitations of Qemu, it would take days for the workflow to finish if we do that. Have to wait for dedicated hardware. But who knows? This might be possible already 🤷🏻‍♂️. We just don't have enough time to put into research sadly.

@thecodrr
Copy link
Author

@m4heshd
Copy link
Owner

m4heshd commented Jun 11, 2024

That is indeed great news. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request Implemented ✅ This feature has been successfully implemented
Projects
None yet
Development

No branches or pull requests

2 participants