docs: complex table filters example #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tibuurcio
commented
Nov 12, 2024
| @@ -38,7 +38,7 @@ const preview: Preview = { | |||
| ], | |||
| 'Candidate Components', | |||
| 'UX Patterns', | |||
| ['Table', ['Table', 'Filters']], | |||
There was a problem hiding this comment.
This sorting is not working when taking stories into consideration. Need to dig deeper to understand why.
tibuurcio
commented
Nov 12, 2024
| } from 'src/components' | ||
| import { DatePickerWithDisabledYears } from 'src/components/data-entry/DatePicker/DatePicker.stories' | ||
| import { SelectWithRangePicker } from 'docs/Candidate Components/Directory/Date Range Filter/SelectWithRangePicker' | ||
|
|
There was a problem hiding this comment.
Extracted everything table related that would be re-used into TableStoryUtils.tsx
tibuurcio
commented
Nov 13, 2024
|
|
||
| const preview: Preview = { | ||
| parameters: { | ||
| layout: 'centered', | ||
| options: { | ||
| // TODO https://mparticle-eng.atlassian.net/browse/UNI-1214 |
There was a problem hiding this comment.
Tried implementing this on this PR but it's more complex than I was expecting, to pulled it out.
| @@ -0,0 +1,201 @@ | |||
| import type { ReactNode } from 'react' | |||
There was a problem hiding this comment.
Essencially pulled from Observability example, but kept everything in a single file and simplified a lot of it. No logic included, only UI.
| @@ -1,5 +1,5 @@ | |||
| import { Collapse as AntCollapse } from 'antd' | |||
| import { type CollapseProps as AntCollapseProps } from 'antd' | |||
| import type { CollapseProps as AntCollapseProps } from 'antd' | |||
There was a problem hiding this comment.
suggested by eslint
gabyzif
approved these changes
Nov 13, 2024
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Documentation work and a change to an ESLint rule.
This PR brings the Observability complex filters implementation in a simplified version as to showcase an example of complex table filters to be used in the library.
New structure:
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)